cosmo-eccodes-definitions: Update maintainers #1034
Conversation
|
|
Hi Dominic
Would you explain to me, what I have to do as a maintainer? Then I would accept to take the responsibility for eccodes-cosmo-resources.
Best regards
Petra
From: Dominic Hofer ***@***.***>
Sent: Tuesday, November 26, 2024 4:48 PM
To: C2SM/spack-c2sm ***@***.***>
Cc: Baumann Petra ***@***.***>; Mention ***@***.***>
Subject: [C2SM/spack-c2sm] cosmo-eccodes-definitions: Update maintainers (PR #1034)
@petrabaumann<https://github.com/petrabaumann> I'm leaving MeteoSwiss. So this package needs a new maintainer. Are you willing to adopt it? Since you create new cosmo-eccodes-definitions, I think you would be a fit.
…________________________________
You can view, comment on, or merge this pull request online at:
#1034
Commit Summary
* f9767f8<f9767f8> cosmo-eccodes-definitions: Update maintainers
File Changes
(1 file<https://github.com/C2SM/spack-c2sm/pull/1034/files>)
* M repos/c2sm/packages/cosmo-eccodes-definitions/package.py<https://github.com/C2SM/spack-c2sm/pull/1034/files#diff-30ade49d1bd223c98e2b16898fcb3a54ba634eefa0cceb58f6c784308c531315> (2)
Patch Links:
* https://github.com/C2SM/spack-c2sm/pull/1034.patch
* https://github.com/C2SM/spack-c2sm/pull/1034.diff
—
Reply to this email directly, view it on GitHub<#1034>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD7KHNHDEXQFNXDIM3IGEK32CSJZJAVCNFSM6AAAAABSQYIWWSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY4TKMJXGI3DSOI>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
|
As a maintainer you would be asked to review pull requests, which change this package description. By "package description" I mean the code in |
There was a problem hiding this comment.
OK, I agree to take over the role of the maintainer.
I already have a suggestion for a change:
depends_on('[email protected]',
type=('build', 'link', 'run'),
when='@2.25.0.1:')$
should be replaced by
depends_on('[email protected]',
type=('build', 'link', 'run'),
when='@2.25.0.1:'2.25.0.3)
Who would review, if I created a PR for that?
|
Anyone can review any PR. |
|
Since 2.25.0.3 is currently the highest version number listed in this package description, |
|
Thanks for the explanation. |
@petrabaumann I'm leaving MeteoSwiss. So this package needs a new maintainer. Are you willing to adopt it? Since you create new cosmo-eccodes-definitions, I think you would be a fit.